Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/compat_handler_decorator #131

Merged
merged 3 commits into from
Sep 21, 2023
Merged

feat/compat_handler_decorator #131

merged 3 commits into from
Sep 21, 2023

Conversation

JarbasAl
Copy link
Member

add a decorator to specify backwards compatible alternate handlers for specific ovos/mycroft versions

@JarbasAl JarbasAl added enhancement New feature or request refactor code improvements with no functional changes labels Sep 21, 2023
@JarbasAl JarbasAl requested a review from NeonDaniel September 21, 2023 01:56
@codecov
Copy link

codecov bot commented Sep 21, 2023 •
edited
Loading

Codecov Report

Patch coverage: 52.63% and project coverage change: +0.81% 🎉

Comparison is base (8027bda) 58.10% compared to head (456df9e) 58.92%.
Report is 2 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev     #131      +/-   ##
==========================================
+ Coverage   58.10%   58.92%   +0.81%     
==========================================
  Files          33       34       +1     
  Lines        3268     3318      +50     
==========================================
+ Hits         1899     1955      +56     
+ Misses       1369     1363       -6
Files Changed Coverage Δ
ovos_workshop/version.py 0.00% <0.00%> (ø)
ovos_workshop/skills/ovos.py 59.06% <34.14%> (+4.57%) ⬆️
ovos_workshop/skills/common_query_skill.py 38.39% <40.00%> (+3.61%) ⬆️
ovos_workshop/skills/base.py 75.56% <41.93%> (-0.62%) ⬇️
ovos_workshop/skills/fallback.py 61.22% <54.54%> (+3.58%) ⬆️
ovos_workshop/skills/mycroft_skill.py 58.90% <56.81%> (+2.18%) ⬆️
ovos_workshop/decorators/compat.py 84.84% <84.84%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl
feat/compat_handler_decorator
58b8f86 
add a decorator to specify backwards compatible alternate handlers for specific ovos/mycroft versions
@JarbasAl JarbasAl force-pushed the feat/compat_handler_Decorator branch from 76a2482 to 58b8f86 Compare September 21, 2023 03:15
@JarbasAl JarbasAl merged commit 053abd7 into dev Sep 21, 2023
9 checks passed
@JarbasAl JarbasAl deleted the feat/compat_handler_Decorator branch September 21, 2023 13:11
This was referenced Dec 29, 2023
Closed
Merged
@NeonDaniel NeonDaniel mentioned this pull request Jan 3, 2024
Closed
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeonDaniel NeonDaniel Awaiting requested review from NeonDaniel

Assignees
No one assigned
Labels
enhancement New feature or request refactor code improvements with no functional changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JarbasAl